Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#1729 - Fix filters skipping on activity report #17200

Merged
merged 1 commit into from
Apr 30, 2020
Merged

dev/core#1729 - Fix filters skipping on activity report #17200

merged 1 commit into from
Apr 30, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Apr 30, 2020 •
edited by totten
Loading

Overview

On the "Activity Detail" report, setting the "Source Name" filter on a report has no effect on the results.

See also: https://lab.civicrm.org/dev/core/-/issues/1729

Before

Suppose you take these steps:

  1. open Activity Details report.
  2. go to "Filters" (tab)
  3. "Source Name" : "Contains" : [any text]
  4. Preview results

Current behaviour

  • notice 80 results
  • results do not change when changing the 'source name' filter
  • no errors reported

After

Report results are filtered (based on the filter values)

Technical Details

Regression from https://github.com/civicrm/civicrm-core/pull/16672/files as the operator is wrong

ie we went from

($op !== 'nnll' || $op !== 'nll')

to

!($op !== 'nnll' || $op !== 'nll')

when it should be

!($op === 'nnll' || $op === 'nll')

Comments

@MegaphoneJon FYI

@civibot
Copy link

civibot bot commented Apr 30, 2020

(Standard links)

@civibot civibot bot added the 5.25 label Apr 30, 2020
@seamuslee001
Copy link
Contributor

Test fail unrelated.

I tested the report and was able to confirm that this fixes the name fields and also confirmed that the null and not null filters on the other fields still worked merging

@seamuslee001 seamuslee001 merged commit bddff5e into civicrm:5.25 Apr 30, 2020
@seamuslee001 seamuslee001 deleted the rep branch April 30, 2020 07:17
@seamuslee001 seamuslee001 mentioned this pull request Apr 30, 2020
Merged
@totten totten changed the title dev/core#1729 Fix filters skipping on activity report dev/core#1729 - Fix filters skipping on activity report Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001